* General access to device
  We should hold a spinlock / semaphore before accessing the PCI
  registers, in order to ensure that the WRITEIO_DELAY (which must be
  respected on PCI) is enforced. We may also want to grab a semaphore
  before accessing the direct memory window, in order not to fiddle with
  it twice.

* Monitor mode

> Monitor mode seems OK (Adhoc beacons are the only kind of 802.11 traffic I can 
> generate in the area where I live, so this is not a good test...). By the 
> way, JB, why do you set chan_m1 to P54U_TX_CONTROL_CHANNEL_MAGIC1_SCAN and	
> chan_m2 to P54U_TX_CONTROL_CHANNEL_MAGIC2_SCAN when entering monitor mode, 
> instead of leaving them to P54U_TX_CONTROL_CHANNEL_MAGIC1_TX and 
> P54U_TX_CONTROL_CHANNEL_MAGIC2_TX like previous driver releases did ? 

Good question, i'm glad you asked ! well, no reason, really. Didn't even
know something had changed. =]

> Doing 
> so causes the WG111 to send back oversized bogus data frames (I haven't tried 
> with the Gigaset nor attempted to dump those frames for now, I'd like to know 
> why you changed this first...)

* LED protocol

> Another small thing, the LED control packets' meaning is reversed on GW3887s. 
> When you want to turn the LEDs off, you need to tell the device to turn them 
> on, and vice versa.